Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes docs and fixed build_docs.sh to only build xml for doxygen #4837

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

acostadon
Copy link
Contributor

@acostadon acostadon added the doc Documentation label Dec 18, 2024
@acostadon acostadon self-assigned this Dec 18, 2024
@acostadon acostadon requested review from a team as code owners December 18, 2024 18:05
@acostadon acostadon requested a review from gforsyth December 18, 2024 18:05
@github-actions github-actions bot added the ci label Dec 18, 2024
@jameslamb jameslamb requested review from jameslamb and removed request for gforsyth December 18, 2024 18:05
@jameslamb jameslamb added DO NOT MERGE Hold off on merging; see PR for details non-breaking Non-breaking change labels Dec 18, 2024
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Now that https://github.com/rapidsai/cugraph-docs/pull/65 is merged, I think this is safe to merge as soon as we see a successful build on branch-25.02 there.

Here's the build to watch: https://github.com/rapidsai/cugraph-docs/actions/runs/12398664118/job/34611886692

# TMP_DIR=$(mktemp -d)
# export XML_DIR_${PROJECT^^}="$TMP_DIR"
# curl "https://d1664dvumjb44w.cloudfront.net/${PROJECT}/xml_tar/${RAPIDS_VERSION_NUMBER}/xml.tar.gz" | tar -xzf - -C "${TMP_DIR}"
# done
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah great, thanks for removing this too!

@jameslamb jameslamb changed the title removes docs and fixed ci/build.docs to only build xml for doxygen removes docs and fixed build_docs.sh to only build xml for doxygen Dec 18, 2024
@jameslamb jameslamb removed the DO NOT MERGE Hold off on merging; see PR for details label Dec 31, 2024
@jameslamb
Copy link
Member

Merging based on offline conversation with @acostadon . We are close to having docs-build set up from https://github.com/rapidsai/cugraph-docs, and preventing docs builds from this repo will help there.

@jameslamb
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit b440e30 into rapidsai:branch-25.02 Dec 31, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci doc Documentation non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants