Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better communicate expectations of data order/contiguousness #5975

Open
wants to merge 3 commits into
base: branch-24.08
Choose a base branch
from
Open

Better communicate expectations of data order/contiguousness #5975

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a295857
Better communicate expectations of F/C contiguousness
viclafargue Jul 24, 2024
02ad931
Apply review
viclafargue Jul 29, 2024
74190ed
Merge branch 'branch-24.08' into wrong-order-copy-prevention
viclafargue Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion python/cuml/cuml/internals/array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import pickle

from cuml.internals.global_settings import GlobalSettings
from cuml.internals.logger import debug
from cuml.internals.logger import debug, info
from cuml.internals.mem_type import MemoryType, MemoryTypeError
from cuml.internals.memory_utils import class_with_cupy_rmm, with_cupy_rmm
from cuml.internals.safe_imports import (
Expand Down Expand Up @@ -1172,6 +1172,11 @@ def from_input(
if (
not fail_on_order and order != arr.order and order != "K"
) or make_copy:
info(
f"Expected {order} major order but got something else."
viclafargue marked this conversation as resolved.
Show resolved Hide resolved
" Converting data; this will result in additional memory"
" utilization."
)
arr = cls(
arr.mem_type.xpy.array(
arr.to_output("array"), order=order, copy=make_copy
Expand Down
Loading