-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kernel PCA: Python and Benchmarking Code #5988
Open
tomasjoh
wants to merge
3
commits into
rapidsai:branch-24.10
Choose a base branch
from
tomasjoh:fea-kernel-pca-python
base: branch-24.10
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
tomasjoh
changed the title
Kernel PCAPython and benchmarking
Kernel PCA: Python and Benchmarking Code
Jul 27, 2024
tomasjoh
commented
Jul 27, 2024
def _build_params(self, n_rows, n_cols): | ||
IF GPUBUILD == 1: | ||
cdef paramsKPCA *params = new paramsKPCA() | ||
params.n_components = min(self.n_components_ or n_rows, n_rows) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sklearn reference for setting n_components
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR relies on C++ implementation from #5987
Adds Python, and benchmarking code for Kernel PCA. This implementation of Kernel PCA support fit(), transform(), and fit_transform().
Feature request: #1317
Tests and benchmarks were performed on an EC2
g4dn.xlarge
instance with CUDA 12.2.Click here to see environment details
Notes for Reviewers
The API deviates from SKlearn by not supporting options for these fields: fit_inverse_transform, random_state, n_jobs, max_iter. If a user tries to set one of them a
NotImplementedError
will be raised.The Criteria of Done mentions making the class pickable in
cuml/tests/test_pickle.py
. I couldn't find a PCA reference for this. Would appreciate pointers if additional work is needed.Benchmarks
From
notebooks/tools/cuml_benchmarks.ipynb
Benchmark output
We see an even greater speedup when we set n_components = n_samples. Setting n_components to n_samples is the same as default behavior, except zero eigenvalues aren't removed.
Manual tests
Kernel PCA with RBF kernel
code
Kernel PCA with poly kernel
code
Projecting testing data
Case is copied from sklearn, except it uses cuML PCA and kernelPCA
code
Definition of Done Criteria Checklist
Python Checklist
Design
cuml/tests/test_pickle.py
input_to_cuml_array
to accept flexible inputs and check their datatypes and usecumlArray.to_output()
to return configurable outputs.CumlArray
Testing
python/cuml/benchmarks/algorithms.py
and benchmarks notebook inpython/cuml/notebooks/tools/cuml_benchmarks.ipynb
Unit test results
Python Test Results