Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rapids-cmake for the logger #6205

Merged
merged 6 commits into from
Jan 6, 2025
Merged

Use rapids-cmake for the logger #6205

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f1adb5e
Update CMake
vyasr Jan 3, 2025
0247781
Update CI scripts
vyasr Jan 3, 2025
213efbb
More CI script updates
vyasr Jan 3, 2025
1c9936a
Typo
vyasr Jan 3, 2025
2f13133
Revert testing changes
vyasr Jan 3, 2025
a0f567e
Update for rapids-cmake changes
vyasr Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,11 +231,8 @@ endif()
rapids_cpm_init()
rapids_cmake_install_lib_dir(lib_dir)

# Not using rapids-cmake since we never want to find, always download.
CPMAddPackage(
NAME rapids_logger GITHUB_REPOSITORY rapidsai/rapids-logger GIT_SHALLOW FALSE GIT_TAG
4df3ee70c6746fd1b6c0dc14209dae2e2d4378c6 VERSION 4df3ee70c6746fd1b6c0dc14209dae2e2d4378c6
)
include(${rapids-cmake-dir}/cpm/rapids_logger.cmake)
rapids_cpm_rapids_logger()
rapids_make_logger(
ML EXPORT_SET cuml-exports LOGGER_HEADER_DIR include/cuml/common/ LOGGER_MACRO_PREFIX CUML LOGGER_TARGET cuml_logger
)
Expand Down
Loading