Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FAISS with cuVS enabled in cuvs-bench #561

Merged
merged 33 commits into from
Jan 29, 2025
Merged

FAISS with cuVS enabled in cuvs-bench #561

merged 33 commits into from
Jan 29, 2025

Conversation

tarang-jain
Copy link
Contributor

Mostly adapted from rapidsai/raft#2026

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 8, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@tarang-jain tarang-jain added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Jan 9, 2025
achirkin
achirkin requested changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@achirkin achirkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are couple suggestions on my side to keep the faiss behavior in line with other algorithms.

cpp/bench/ann/src/faiss/faiss_gpu_benchmark.cu Outdated Show resolved Hide resolved
@tarang-jain tarang-jain marked this pull request as ready for review January 22, 2025 17:19
@tarang-jain tarang-jain requested review from a team as code owners January 22, 2025 17:19
achirkin
achirkin approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@achirkin achirkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, no more complaints on my side :)

@tarang-jain
Copy link
Contributor Author

/merge

@tarang-jain tarang-jain self-assigned this Jan 28, 2025
@rapids-bot rapids-bot bot merged commit a84788d into rapidsai:branch-25.02 Jan 29, 2025
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achirkin achirkin achirkin approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees

@tarang-jain tarang-jain

Labels
CMake cpp improvement Improves an existing functionality non-breaking Introduces a non-breaking change Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tarang-jain @cjnolet @achirkin