Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add verify-copyright pre-commit hook #1423

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Add verify-copyright pre-commit hook #1423

merged 1 commit into from
Feb 10, 2025

Conversation

gforsyth
Copy link
Contributor

@gforsyth gforsyth commented Jan 6, 2025

Adds a pre-commit hook to ensure files have an up-to-date copyright notice.

@gforsyth gforsyth requested a review from a team as a code owner January 6, 2025 20:57
@gforsyth gforsyth requested a review from AyodeAwe January 6, 2025 20:57
@gforsyth gforsyth added improvement Improvement / enhancement to an existing function ci non-breaking Non-breaking change labels Jan 6, 2025
@gforsyth gforsyth force-pushed the add-verify-copyright branch from 5e6e931 to c547aa6 Compare January 6, 2025 21:40
@github-actions github-actions bot removed the ci label Jan 6, 2025
@gforsyth gforsyth force-pushed the add-verify-copyright branch from c547aa6 to 5c89ae8 Compare January 22, 2025 14:50
jameslamb
jameslamb requested changes Feb 7, 2025
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one suggestion.

dask-cuda 25.02 is past code freeze at this point, can you re-target this to branch-25.04 please?

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@jameslamb jameslamb removed the request for review from AyodeAwe February 7, 2025 18:45
@gforsyth gforsyth force-pushed the add-verify-copyright branch from 5c89ae8 to 06b3cba Compare February 7, 2025 19:00
@gforsyth gforsyth requested review from a team as code owners February 7, 2025 19:00
@gforsyth gforsyth requested a review from bdice February 7, 2025 19:00
@gforsyth gforsyth changed the base branch from branch-25.02 to branch-25.04 February 7, 2025 19:00
rjzamora
rjzamora approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@rjzamora rjzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gforsyth !

@jameslamb jameslamb removed the request for review from bdice February 7, 2025 19:44
@rjzamora
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit b424ea3 into rapidsai:branch-25.04 Feb 10, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@rjzamora rjzamora rjzamora approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gforsyth @rjzamora @jameslamb