-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add libraft wheels #438
add libraft wheels #438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approving. All looks fine to me.
CUDA 12.0 builds segfaulted (!!!) compiling cuDF:
CUDA 12.5 builds have already progressed beyond that point (successfully compiled cuDF): https://github.com/rapidsai/devcontainers/actions/runs/12813231633/job/35726830742?pr=438 I'm going to stop and restart these builds (since they're still early on), to see if that segfault was something temporary. |
@jameslamb This is something I think we've seen elsewhere in Slack. @mhaseeb123 This appears to be related to rapidsai/cudf#17289.
|
CI on this will probably be blocked until we have a resolution for rapidsai/cudf#17753. We will have to temporarily disable any failing jobs -- seems like 12.0 is affected but perhaps 12.5 is not? Or we can admin-merge. |
If we see the CUDA 12.5 jobs pass, I'm in favor of skipping the CUDA 12.0 jobs until that cuDF issue is resolved. The 12.5 job just made it to RAFT (still in progress), so I'll let it keep running for a bit to at least ensure we see the RAFT-related changes in this PR working. |
🎉 the CUDA 12.5 CI jobs ran successfully! https://github.com/rapidsai/devcontainers/actions/runs/12813231633/job/35729224938?pr=438 That's strong evidence that rapidsai/raft#2531 will work with RAPIDS devcontainers. |
I opened #439 to disable CUDA 12.0 RAPIDS builds in devcontainers for now. |
features/src/rapids-build-utils/opt/rapids-build-utils/manifest.yaml
Outdated
Show resolved
Hide resolved
CI is blocked until rapidsai/cuvs#454 goes in. xref: rapidsai/raft#2487 (comment) I am going to merge this once the CUDA 12.5 pip devcontainer gets past RAFT. We expect it will fail on cuVS. (It is currently halfway done building cudf.) |
Pulling just the RAFT-related changes off of #438
Complements rapidsai/raft#2531
Notes for Reviewers
Proposing:
rapidsai/raft
and see it pass CI