Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward-merge branch-24.10 into branch-24.12 #730

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

rapids-bot[bot]
Copy link

@rapids-bot rapids-bot bot commented Oct 3, 2024

Forward-merge triggered by push to branch-24.10 that creates a PR to keep branch-24.12 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.

This fixes failures in the new testing workflow from #690.

**Update:** the root cause was that `rapids-conda-retry` is sending `2>&1`. The warning is being sent to stderr as intended. The old contents are partially incorrect. We can still solve this by providing `--quiet`, without needing to change `rapids-conda-retry`.

<details><summary>Old issue contents</summary>

Output like this is shown, even with the `--json` flag to conda:
```
==> WARNING: A newer version of conda exists. <==
    current version: 24.9.0
    latest version: 24.9.1

Please update conda by running

    $ conda update -n base -c conda-forge conda
```

The only way to make the output "proper JSON" is to pass `--quiet` as well.


This seems like unintentional behavior from conda. The docs from `conda create --help` literally say:
```
--json                Report all output as json. Suitable for using conda programmatically.
```

</details>

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - James Lamb (https://github.com/jameslamb)
  - Mike Sarahan (https://github.com/msarahan)

URL: #729
@rapids-bot rapids-bot bot requested a review from a team as a code owner October 3, 2024 19:15
@rapids-bot rapids-bot bot requested a review from raydouglass October 3, 2024 19:15
@GPUtester GPUtester merged commit e2e9d6b into branch-24.12 Oct 3, 2024
Copy link
Author

rapids-bot bot commented Oct 3, 2024

SUCCESS - forward-merge complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants