Skip to content

Commit

Permalink
Fix conda recipe for kvikio (#381)
Browse files Browse the repository at this point in the history
Use `build.sh` in `meta.yaml`, and pass `-DFIND_KVIKIO_CPP=ON` to CMake.

xref: #379 (comment)

Fixes #378

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Jake Awe (https://github.com/AyodeAwe)

URL: #381
  • Loading branch information
KyleFromNVIDIA authored May 16, 2024
1 parent 4355c29 commit 261445b
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
5 changes: 5 additions & 0 deletions build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,11 @@ if hasArg -n; then
INSTALL_TARGET=""
fi

# Append `-DFIND_KVIKIO_CPP=ON` to EXTRA_CMAKE_ARGS unless a user specified the option.
if [[ "${EXTRA_CMAKE_ARGS}" != *"DFIND_KVIKIO_CPP"* ]]; then
EXTRA_CMAKE_ARGS="${EXTRA_CMAKE_ARGS} -DFIND_KVIKIO_CPP=ON"
fi

# If clean given, run it prior to any other steps
if hasArg clean; then
# If the dirs to clean are mounted dirs in a container, the
Expand Down
4 changes: 4 additions & 0 deletions conda/recipes/kvikio/build.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#!/bin/bash
# Copyright (c) 2018-2024, NVIDIA CORPORATION.

./build.sh kvikio
3 changes: 0 additions & 3 deletions conda/recipes/kvikio/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@ build:
- SCCACHE_S3_KEY_PREFIX=kvikio-linux64 # [linux64]
- SCCACHE_S3_USE_SSL
- SCCACHE_S3_NO_CREDENTIALS
script:
- cd python
- python -m pip install . -vv
ignore_run_exports_from:
{% if cuda_major == "11" %}
- {{ compiler('cuda11') }}
Expand Down

0 comments on commit 261445b

Please sign in to comment.