-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move content of the Python pkg to subdirectory python/kvikio/ #392
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny niggle, approving python changes.
I think the devcontainer failures will require a change to https://github.com/rapidsai/devcontainers/blob/bff06939d44479ae1f63c3f128881d6d533de99c/features/src/rapids-build-utils/opt/rapids-build-utils/manifest.yaml#L48 This change would be similar to the changes in rapidsai/devcontainers#263 when we moved It looks like rapidsai/devcontainers#283 does this and more? |
@bdice Let's merge this PR first. I would like to proceed as follows:
|
@hcho3 Sounds fine to me. You'll probably need to get admin-merges to work around the circular dependency between this PR and the one you plan to file to |
Admin merging due to circular dependency |
Part of #369