Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move content of the Python pkg to subdirectory python/kvikio/ #392

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Jun 8, 2024

Part of #369

@hcho3 hcho3 requested review from a team as code owners June 8, 2024 02:40
@hcho3 hcho3 requested a review from bdice June 8, 2024 02:40
@hcho3 hcho3 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jun 8, 2024
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny niggle, approving python changes.

python/kvikio/pyproject.toml Outdated Show resolved Hide resolved
@bdice
Copy link
Contributor

bdice commented Jun 10, 2024

I think the devcontainer failures will require a change to https://github.com/rapidsai/devcontainers/blob/bff06939d44479ae1f63c3f128881d6d533de99c/features/src/rapids-build-utils/opt/rapids-build-utils/manifest.yaml#L48

This change would be similar to the changes in rapidsai/devcontainers#263 when we moved rmm's package directory from python to python/rmm.

It looks like rapidsai/devcontainers#283 does this and more?

@hcho3
Copy link
Contributor Author

hcho3 commented Jun 10, 2024

@bdice Let's merge this PR first. I would like to proceed as follows:

  1. Merge this PR.
  2. Submit a smaller PR to devcontainer to account for the directory change (python -> python/kvikio).
  3. Merge add wheel output #369 to add libkvikio and create C++ wheels
  4. Submit a separate PR to devcontainer to add libkvikio.

@bdice
Copy link
Contributor

bdice commented Jun 10, 2024

@hcho3 Sounds fine to me. You'll probably need to get admin-merges to work around the circular dependency between this PR and the one you plan to file to rapidsai/devcontainers.

@raydouglass
Copy link
Member

Admin merging due to circular dependency

@raydouglass raydouglass merged commit 88033f4 into rapidsai:branch-24.08 Jun 10, 2024
33 of 35 checks passed
@hcho3 hcho3 deleted the wheel-build-part1 branch June 10, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants