This repository has been archived by the owner on Dec 21, 2018. It is now read-only.

[REVIEW] NULL support for hash-based group by#140

Open

jrhemstad wants to merge 24 commits intorapidsai:masterfrom jrhemstad:fea-ext-null-suport-hash-groupby

+355-62

Commits on Sep 15, 2018

Commits on Sep 17, 2018

Commits on Sep 19, 2018

Added checking for NULLs in the aggregation column.
jrhemstad
committed

Commits on Sep 20, 2018

Added function to set a specified bit in a validity bit mask.
jrhemstad
committed
Updated handling of NULLs in the aggregation column such that NULLs are ignored, unless all of the values for a given key are NULL.
jrhemstad
committed
Updated setting the validity bits in the aggregation output to use atomicOrs to avoid race conditions.
jrhemstad
committed
Merge remote-tracking branch 'origin/master' into fea-ext-null-suport-hash-groupby
jrhemstad
committed
Added kernel to gather the validity bits of a gdf_column. Used the kernel to rearrange the validity bits of the aggregation output column after sorting the results.
jrhemstad
committed
Fixed bug where the wrong bit was getting set in the aggregation output validity mask during the extraction kernel.
jrhemstad
committed
Corrected the AVG aggregator implementation so the validity bitmask of the AVG aggregator will get set correctly.
jrhemstad
committed
Added check to ensure we don't try and sort the result if the output size is zero.
jrhemstad
committed
Return an error if the output aggregation column's nullmask isn't allocated.
jrhemstad
committed
No longer return an error if the aggregation column's validity buffer isn't allocated.
jrhemstad
committed
Updated the build_aggregation_kernel for Count such that the aggregation output can never be Null. Instead, an aggregation of all NULLs for Count will just return 0.
jrhemstad
committed
Updated scope of the insert location variable in the Count overload of build aggregation table.
jrhemstad
committed

Commits on Sep 25, 2018

Merge remote-tracking branch 'public/master' into fea-ext-null-suport-hash-groupby
jrhemstad
committed