Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix recently updated PR checker #195

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

AyodeAwe
Copy link
Contributor

Updates the recently_updated plugin to correctly filter out forward merger PRs.

Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes look good to me.

are there any other areas where the isGPUTesterPR function should be replaced? is this function needed anymore? are all of the automated PRs now opened by the rapids-bot?

@AyodeAwe
Copy link
Contributor Author

these changes look good to me.

are there any other areas where the isGPUTesterPR function should be replaced? is this function needed anymore? are all of the automated PRs now opened by the rapids-bot?

I think there are a few places we need to update, but these don't have to go in this PR. I am making a note of these and I will create an issue today.

@AyodeAwe
Copy link
Contributor Author

Ray and I are discussing switching the release PRs back to being authored by GPUTester, which would mean we need to continue accounting for it in the branch_checker plugin and re-introduce it into the recently_updated plugin.

But this might require a significant refactoring of the test fixtures in the code base. So I think we can separately get this PR merged as a fix for the issue reported in ops#3624

@AyodeAwe AyodeAwe merged commit e9cf434 into rapidsai:main Nov 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants