Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 25.04 #41

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Add 25.04 #41

merged 1 commit into from
Jan 23, 2025

Conversation

raydouglass
Copy link
Member

Just adds 25.04 as a copy of 25.02.

@raydouglass raydouglass marked this pull request as ready for review January 23, 2025 18:14
@raydouglass raydouglass requested a review from a team as a code owner January 23, 2025 18:15
@raydouglass raydouglass requested a review from jameslamb January 23, 2025 18:15
@raydouglass raydouglass merged commit cd3f153 into rapidsai:main Jan 23, 2025
7 checks passed
@raydouglass raydouglass deleted the add-25.04 branch January 23, 2025 19:25
Copy link

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn’t get my review submitted before this was merged. Apologies, just juggling a lot of tasks. I had one question.

"libcugraph": {
"has_conda_package": true,
"has_cuda_suffix": true,
"has_wheel_package": false,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have libcugraph wheels now. Are there other libraries that need similar updates?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#40 would fix this.

I've had it up in draft for a couple days, was hoping to do a single "all the C++ wheels updates" PR with updates like that. But that was anticipating the cuML would merge soon, and it still hasn't (rapidsai/cuml#6199 (comment))

I just removed cuML from that and put it up for review.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha an hour after I wrote that, we merged cuML... #40 will now get 25.02 and 25.04 metadata here fully up to date with the new C++ wheels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants