-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration for pre-commit.ci, update pre-commit hooks #1746
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e808707
Add configuration for pre-commit.ci, and reformat config file.
bdice da45bfd
Update hooks.
bdice cb3d62f
Fix style.
bdice 20444fb
Fix style.
bdice a30f3c6
Try rerunning pre-commit.ci.
bdice de591b9
Skip verify-alpha-spec hook in pre-commit.ci.
bdice 5861ae4
Merge branch 'branch-25.02' into pre-commit-ci
bdice File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,91 +1,100 @@ | ||
# Copyright (c) 2022-2023, NVIDIA CORPORATION. | ||
# Copyright (c) 2022-2024, NVIDIA CORPORATION. | ||
ci: | ||
autofix_commit_msg: "[pre-commit.ci] auto code formatting" | ||
autofix_prs: false | ||
autoupdate_branch: "" | ||
autoupdate_commit_msg: "[pre-commit.ci] pre-commit autoupdate" | ||
autoupdate_schedule: quarterly | ||
skip: ["verify-alpha-spec"] | ||
submodules: false | ||
|
||
repos: | ||
- repo: https://github.com/pre-commit/pre-commit-hooks | ||
rev: v4.3.0 | ||
hooks: | ||
- id: trailing-whitespace | ||
- id: end-of-file-fixer | ||
- repo: https://github.com/PyCQA/isort | ||
rev: 5.12.0 | ||
hooks: | ||
- id: isort | ||
args: ["--settings-path=python/rmm/pyproject.toml"] | ||
files: python/.* | ||
types_or: [python, cython, pyi] | ||
- repo: https://github.com/ambv/black | ||
rev: 22.3.0 | ||
hooks: | ||
- id: black | ||
args: ["--config=python/rmm/pyproject.toml"] | ||
- repo: https://github.com/MarcoGorelli/cython-lint | ||
rev: v0.15.0 | ||
hooks: | ||
- id: cython-lint | ||
- repo: https://github.com/pre-commit/mirrors-clang-format | ||
rev: v16.0.6 | ||
hooks: | ||
- id: clang-format | ||
types_or: [c, c++, cuda] | ||
args: ["-fallback-style=none", "-style=file", "-i"] | ||
- repo: https://github.com/sirosen/texthooks | ||
rev: 0.4.0 | ||
hooks: | ||
- id: fix-smartquotes | ||
exclude: | | ||
(?x)^( | ||
^benchmarks/utilities/cxxopts.hpp | ||
) | ||
- repo: https://github.com/codespell-project/codespell | ||
rev: v2.2.4 | ||
hooks: | ||
- id: codespell | ||
exclude: | | ||
(?x)^( | ||
pyproject.toml| | ||
benchmarks/utilities/cxxopts.hpp | ||
) | ||
- repo: local | ||
hooks: | ||
- id: cmake-format | ||
name: cmake-format | ||
entry: ./scripts/run-cmake-format.sh cmake-format | ||
language: python | ||
types: [cmake] | ||
# Note that pre-commit autoupdate does not update the versions | ||
# of dependencies, so we'll have to update this manually. | ||
additional_dependencies: | ||
- cmakelang==0.6.13 | ||
- id: cmake-lint | ||
name: cmake-lint | ||
entry: ./scripts/run-cmake-format.sh cmake-lint | ||
language: python | ||
types: [cmake] | ||
# Note that pre-commit autoupdate does not update the versions | ||
# of dependencies, so we'll have to update this manually. | ||
additional_dependencies: | ||
- cmakelang==0.6.13 | ||
- id: doxygen-check | ||
name: doxygen-check | ||
entry: ./scripts/doxygen.sh | ||
types_or: [file] | ||
language: system | ||
pass_filenames: false | ||
verbose: true | ||
- repo: https://github.com/astral-sh/ruff-pre-commit | ||
rev: v0.0.278 | ||
hooks: | ||
- id: ruff | ||
files: python/.*$ | ||
- repo: https://github.com/rapidsai/pre-commit-hooks | ||
rev: v0.4.0 | ||
hooks: | ||
- id: verify-copyright | ||
- id: verify-alpha-spec | ||
- repo: https://github.com/rapidsai/dependency-file-generator | ||
rev: v1.16.0 | ||
hooks: | ||
- id: rapids-dependency-file-generator | ||
args: ["--clean"] | ||
- repo: https://github.com/pre-commit/pre-commit-hooks | ||
rev: v5.0.0 | ||
hooks: | ||
- id: trailing-whitespace | ||
- id: end-of-file-fixer | ||
- repo: https://github.com/PyCQA/isort | ||
rev: 5.13.2 | ||
hooks: | ||
- id: isort | ||
args: ["--settings-path=python/rmm/pyproject.toml"] | ||
files: python/.* | ||
types_or: [python, cython, pyi] | ||
- repo: https://github.com/ambv/black | ||
rev: 24.10.0 | ||
hooks: | ||
- id: black | ||
args: ["--config=python/rmm/pyproject.toml"] | ||
- repo: https://github.com/MarcoGorelli/cython-lint | ||
rev: v0.16.6 | ||
hooks: | ||
- id: cython-lint | ||
- repo: https://github.com/pre-commit/mirrors-clang-format | ||
rev: v16.0.6 | ||
hooks: | ||
- id: clang-format | ||
types_or: [c, c++, cuda] | ||
args: ["-fallback-style=none", "-style=file", "-i"] | ||
- repo: https://github.com/sirosen/texthooks | ||
rev: 0.6.8 | ||
hooks: | ||
- id: fix-smartquotes | ||
exclude: | | ||
(?x)^( | ||
^benchmarks/utilities/cxxopts.hpp | ||
) | ||
- repo: https://github.com/codespell-project/codespell | ||
rev: v2.3.0 | ||
hooks: | ||
- id: codespell | ||
exclude: | | ||
(?x)^( | ||
pyproject.toml| | ||
benchmarks/utilities/cxxopts.hpp | ||
) | ||
- repo: local | ||
hooks: | ||
- id: cmake-format | ||
name: cmake-format | ||
entry: ./scripts/run-cmake-format.sh cmake-format | ||
language: python | ||
types: [cmake] | ||
# Note that pre-commit autoupdate does not update the versions | ||
# of dependencies, so we'll have to update this manually. | ||
additional_dependencies: | ||
- cmakelang==0.6.13 | ||
- id: cmake-lint | ||
name: cmake-lint | ||
entry: ./scripts/run-cmake-format.sh cmake-lint | ||
language: python | ||
types: [cmake] | ||
# Note that pre-commit autoupdate does not update the versions | ||
# of dependencies, so we'll have to update this manually. | ||
additional_dependencies: | ||
- cmakelang==0.6.13 | ||
- id: doxygen-check | ||
name: doxygen-check | ||
entry: ./scripts/doxygen.sh | ||
types_or: [file] | ||
language: system | ||
pass_filenames: false | ||
verbose: true | ||
- repo: https://github.com/astral-sh/ruff-pre-commit | ||
rev: v0.8.2 | ||
hooks: | ||
- id: ruff | ||
files: python/.*$ | ||
- repo: https://github.com/rapidsai/pre-commit-hooks | ||
rev: v0.4.0 | ||
hooks: | ||
- id: verify-copyright | ||
- id: verify-alpha-spec | ||
- repo: https://github.com/rapidsai/dependency-file-generator | ||
rev: v1.16.0 | ||
hooks: | ||
- id: rapids-dependency-file-generator | ||
args: ["--clean"] | ||
|
||
default_language_version: | ||
python: python3 | ||
python: python3 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened an issue for this: rapidsai/pre-commit-hooks#58
@KyleFromNVIDIA If you have time and want to take a look, feel free. I don't think this is super important so I am okay with leaving the issue open and doing nothing in the short term.