feat: configurable max_retries #307
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rapiz1
requested changes
Feb 14, 2024
| @@ -208,6 +209,8 @@ pub struct ClientConfig { | |||
| pub heartbeat_timeout: u64, | |||
| #[serde(default = "default_client_retry_interval")] | |||
| pub retry_interval: u64, | |||
| #[serde(default)] | |||
There was a problem hiding this comment.
Is this the correct way to set default value? See also retry_interval
rapiz1
reviewed
Feb 14, 2024
| @@ -543,6 +546,13 @@ impl ControlChannelHandle { | |||
| panic!("{:#}. Break", err); | |||
| } | |||
|
|
|||
| retries += 1; | |||
There was a problem hiding this comment.
I think we actually want to only abort the program when failures are in line. For example, three retry failures in line and abort the program. But your change seems to limit the total retry failures. It's common for long-running instances to have more retry failures because of network outrage. Say it runs for an hour, then fails, and runs for another hour, etc. In that case we don't want to limit the total retry failures, or we can only run for three hours. That said, you want to limit the retry failures in a similar style with the retry_backoff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #283
@rapiz1