Added a master key option #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile in game. The mouse position is saved when toggling off and restored when toggling on again.
raptorswing
reviewed
Jan 15, 2023
Comment on lines
+238
to
+239
| if (active) | ||
| { |
There was a problem hiding this comment.
We should probably add a similar conditional around the joystick.SetBtn call in HandleMouseDown. So that the joystick button won't be stuck in a "firing" state if someone uses the "master" toggle.
There was a problem hiding this comment.
Hmm, not sure how that might happen, since active exclusively wraps SetAxis and does nothing else. SetBtn would just continue to work at all times. I guess that's a matter of taste and also depends on the game. In Flight Sims it's more useful if everything else keeps working.
added 2 commits
January 15, 2023 23:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a master key option which lets you toggle the feeding on/off while in game. Essential for Flight Simulators. Lets you use mouse yoke like in FSX.
Seems a bit finicky in MSFS 2020. Doesn't register at first press always. Not sure whats going on. Maybe to much input handling going on in the background.