-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set proof verifications params in handler, add callaback and proof-pa… #2
Conversation
…rameters data in config
ape.RenderErr(w, problems.BadRequest(validation.Errors{"user_id_hash": fmt.Errorf("failed to parse event data")})...) | ||
userIDHash, err := ExtractEventData(getter) | ||
if err != nil { | ||
Log(r).WithError(err).Errorf("failed to extract user hash from event data", userIDHash) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
printf: (*gitlab.com/distributed_lab/logan/v3.Entry).Errorf call has arguments but no formatting directives (govet)
Log(r).WithError(err).Error("Failed to get user by userId") | ||
ape.RenderErr(w, problems.InternalError()) | ||
Log(r).WithError(err).Error("failed to get user by userID") | ||
ape.RenderErr(w, problems.NotFound()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not found?
if err != nil { | ||
Log(r).WithError(err).Errorf("failed to get user with userHashID [%s]", userIdHash) | ||
Log(r).Error("cannot extract selector from public signals") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not WithError?
…rameters data in config