Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Philox tests #5

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Philox tests #5

wants to merge 9 commits into from

Conversation

aelizaro
Copy link
Collaborator

  • Discard fix
  • Initial bunch of tests

@aelizaro aelizaro requested a review from rarutyun July 26, 2024 11:32
iburyl
iburyl reviewed Jul 29, 2024
View reviewed changes
rng/philox/philox.hpp Outdated
for(std::size_t j = 0; j < n; j++) {
z += (unsigned long long)x[j];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

promotion type is for result_type, not for unsigned long long.
Let unsigned long long be 64 bits; and result_type be 32 bits. promotion type will be 64 bits.
Same example; z=-1; x[0]=1; skipped nothing. Period of this thing is 2^(32*4+2) -> we are in wrong state.

Base automatically changed from philox_reference_implementation to main August 1, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iburyl iburyl iburyl left review comments

@rarutyun rarutyun Awaiting requested review from rarutyun

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aelizaro @iburyl @rarutyun