This repository has been archived by the owner on Nov 22, 2017. It is now read-only.
Make KelasticMulti sort aggregated responses for multiple indexes #250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous KelasticMulti was sorting the response for each index individually, then append the presorted result into the response.
It was also only retrieving a increasingly smaller subset of any subsequent index in an attempt to fit something from all indexes on one page.
This ends up displaying mixed results that are not necessarily ordered by time.
The solution was to get the full target size resultset for each index(50), append them into a single array and then sort.
Pretty much re-did KelasticMulti. Please review thoroughly before merging. :)