Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pico_setup.sh
seems to createbuild_pico
andbuild_pico2
: https://github.com/raspberrypi/pico-setup/blob/master/pico_setup.sh#L82There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that suggests that an alternative approach might be to modify
pico_setup.sh
to use build-directory names that are already covered by the.gitignore
inpico-examples
? ping @liamfraserThe advantage of modifying the
pico-setup
repo instead of thepico-examples
repo, is that edits topico-setup
are made directly onmaster
(and so get "released" immediately); whereas edits topico-examples
get made on thedevelop
branch (and so don't get "released" until @kilograham does the next merge fromdevelop
tomaster
).