async_context_freertos: Add support for configSUPPORT_STATIC_ALLOCATION #2436
Conversation
src/rp2_common/pico_async_context/include/pico/async_context_freertos.h
Outdated
Show resolved
Hide resolved
mbrase
force-pushed
the
freertos-static-task
branch
2 times, most recently
from
968d67b to
636f390
Compare
|
I pushed a new change that does not try to fall back to |
The implementation of async_context_freertos currently assumes that FreeRTOS has been configured with `configSUPPORT_DYNAMIC_ALLOCATION`, which causes it to allocate semaphores, timers and tasks from the heap. However, some projects may prefer `configSUPPORT_STATIC_ALLOCATION`, which requires memory to be allocated ahead of time. This change allows async_context_freertos to support either static or dynamic allocation. The way this works is when `configSUPPORT_STATIC_ALLOCATION` is enabled, `async_context_freertos` struct will reserve extra space for the static objects (e.g. `StaticSemaphore_t`) and it will prefer to use the static creation functions (e.g. `xSemaphoreCreateBinaryStatic()`). For the task creation, the user will be responsible for allocating the stack memory and setting the task_stack field in `async_context_freertos_config_t`. For convenience, The `cyw43_arch_init_default_async_context()` function will reserve `CYW43_TASK_STACK_SIZE` words of stack space in static memory.
mbrase
force-pushed
the
freertos-static-task
branch
from
636f390 to
456856f
Compare
src/rp2_common/pico_async_context/include/pico/async_context_freertos.h
Outdated
Show resolved
Hide resolved
|
LwIP NO_SYS=0 requires configSUPPORT_DYNAMIC_ALLOCATION so that's one use case for having both (it works fine) although I'm not sure why you'd bother? |
In theory you can use your own async context therefore bypassing cyw43_arch_init_default_async_context, which would leave cyw43_async_context_freertos_task_stack unused. Add a #define for this rare situation.
I'm curious, is there any reason that LwIP NO_SYS=0 mode can't use static allocation? (other than needing to update all the calls in |
There's this assert in LwIP. I didn't look any deeper. |
The implementation of async_context_freertos currently assumes that FreeRTOS has been configured with
configSUPPORT_DYNAMIC_ALLOCATION, which causes it to allocate semaphores, timers and tasks from the heap. However, some projects may preferconfigSUPPORT_STATIC_ALLOCATION, which requires memory to be allocated ahead of time. This change allows async_context_freertos to support either static or dynamic allocation.The way this works is when
configSUPPORT_STATIC_ALLOCATIONis enabled,async_context_freertosstruct will reserve extra space for the static objects (e.g.StaticSemaphore_t) and it will prefer to use the static creation functions (e.g.xSemaphoreCreateBinaryStatic()). For the task creation, the user will be responsible for allocating the stack memory and passing it in through the config. If a stack is not provided, then it will fallback to using dynamic allocation for the stack (e.g.xTaskCreate()).