chore: update templates for cargo-generate 0.23.0 #95
Conversation
| authors = ["Josh McKinney <[email protected].com>"] | ||
| authors = ["Orhun Parmaksız <orhunparmaksiz@gmail.com>"] |
There was a problem hiding this comment.
One thing we could do here instead to avoid this bouncing back and forth is to add some sort of env override in the just file that makes this consistent across runs.
| (target: $target:expr, level: $level:expr, $ex:expr) => {{ | ||
| (target: $target:expr, level: $level:expr, $ex:expr) => { | ||
| { | ||
| match $ex { | ||
| value => { | ||
| tracing::event!(target: $target, $level, ?value, stringify!($ex)); | ||
| value | ||
| } | ||
| } | ||
| }}; | ||
| } | ||
| }; | ||
| (level: $level:expr, $ex:expr) => { | ||
| trace_dbg!(target: module_path!(), level: $level, $ex) | ||
| }; |
There was a problem hiding this comment.
This indenting seems a bit weird
There was a problem hiding this comment.
What about instead excluding these files from being parsed by liquid? https://cargo-generate.github.io/cargo-generate/templates/include_exclude.html
There was a problem hiding this comment.
That didn't work for me via top-level cargo-generate.toml. However IIRC it works with individual ones for each template which is not that good. Can you also give it a try?
There was a problem hiding this comment.
for each template which is not that good
What's not good about configuring entire files to not be processed per template? This is instead of putting code around the parts of each file to avoid processing but there's nothing else being processed in that file. I may be missing the logic of that.
There was a problem hiding this comment.
I meant adding the same cargo-generate.toml for each template is not that good. I think it's better if we do that in the top-level config which didn't work for me.
|
I'll merge this as-is for now since it's affecting people and we can make the improvements later on |
See:
cargo-generate-action is not bumped yet: cargo-generate/cargo-generate-action#22