Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pint dependency really optional (py313 compat) #199

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

getzze
Copy link
Contributor

@getzze getzze commented Oct 18, 2024

pint is not compatible with python 3.13 and it may take a while to make it compatible.

pint is a hard dependency for knowit although it is imported in a try..except structure in case it is not installed.

This PR makes two changes:

  • deal with the case of having pint installed but broken (so knowit would work with py313 now and in the future if pint breaks).
  • make pint an optional dependency. To install pint when installing knowit, you would need to use:
    pip install knowit[pint]

On a side note, maybe enzyme and pymediainfo could be made optional dependencies too, as they are not strictly needed for knowit to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant