Reduce bicycle speed to PUSHING_SECTION_SPEED for the tag vehicle=no

ratrun · Apr 21, 2024 · e63a10a · e63a10a
1 parent 906b364
commit e63a10a
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/core/src/main/java/com/graphhopper/routing/util/parsers/BikeCommonAverageSpeedParser.java b/core/src/main/java/com/graphhopper/routing/util/parsers/BikeCommonAverageSpeedParser.java
@@ -208,6 +208,8 @@ else if (way.hasTag("highway", pushingSectionsHighways)
                     speed = Math.min(speed, surfaceSpeed);
             }
         }
+        if (way.hasTag("vehicle", "no"))
+            speed = PUSHING_SECTION_SPEED;
         return speed;
     }
 

diff --git a/core/src/test/java/com/graphhopper/routing/util/parsers/BikeTagParserTest.java b/core/src/test/java/com/graphhopper/routing/util/parsers/BikeTagParserTest.java
@@ -278,6 +278,11 @@ public void testSpeedAndPriority() {
         way.clearTags();
         way.setTag("highway", "trunk");
         assertPriorityAndSpeed(REACH_DESTINATION, 18, way);
+
+        way.clearTags();
+        way.setTag("highway", "cycleway");
+        way.setTag("vehicle", "no");
+        assertPriorityAndSpeed(VERY_NICE, PUSHING_SECTION_SPEED, way);
     }
 
     @Test

diff --git a/core/src/test/java/com/graphhopper/routing/util/parsers/OSMGetOffBikeParserTest.java b/core/src/test/java/com/graphhopper/routing/util/parsers/OSMGetOffBikeParserTest.java
@@ -102,6 +102,11 @@ public void testHandleCommonWayTags() {
         assertFalse(isGetOffBike(way)); // for now only designated will trigger true
         way.setTag("foot", "designated");
         assertTrue(isGetOffBike(way));
+
+        way = new ReaderWay(1);
+        way.setTag("highway", "cycleway");
+        way.setTag("vehicle", "no");
+        assertFalse(isGetOffBike(way));
     }
 
     @Test