RDBC-670 Streaming #238
RDBC-670 Streaming #238
Conversation
|
Please run |
ravendb/documents/commands/stream.py
Outdated
|
|
||
|
|
||
| # todo: https://issues.hibernatingrhinos.com/issue/RavenDB-20033 | ||
| # class StreamCommand(RavenCommand[StreamResultResponse]): |
There was a problem hiding this comment.
should we uncomment/use it somewhere?
There was a problem hiding this comment.
Part of latest commit with document streaming
| @@ -25,7 +25,7 @@ | |||
|
|
|||
|
|
|||
| _T = TypeVar("_T") | |||
| _Operation_T = TypeVar("_Operation_T") | |||
| _Operation_Return_Type = TypeVar("_Operation_Return_Type") | |||
There was a problem hiding this comment.
| _Operation_Return_Type = TypeVar("_Operation_Return_Type") | |
| _T_Operation_Return = TypeVar("_T_Operation_Return") |
| @@ -136,8 +136,8 @@ def for_database(self, database_name: str) -> MaintenanceOperationExecutor: | |||
| return MaintenanceOperationExecutor(self._store, database_name) | |||
|
|
|||
| def send( | |||
| self, operation: Union[VoidMaintenanceOperation, MaintenanceOperation[_Operation_T]] | |||
| ) -> Optional[_Operation_T]: | |||
| self, operation: Union[VoidMaintenanceOperation, MaintenanceOperation[_Operation_Return_Type]] | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
_T in the beginning tells that's a type. Too bad I wasn't that smart to do that myself back then
|
|
||
| result = stream_operation.set_result(command.result) | ||
|
|
||
| return self._yield_result(query_or_raw_query, result), stats |
There was a problem hiding this comment.
query_or_raw_query reminds me times when I've performed duck typing in methods instead of creating 2 separate ones.
Does it matter here, if it's raw or regular query, in terms of the data flow? Is there any if type== that splits the code?
There was a problem hiding this comment.
Doesn's seem like there is any difference, as in the very first line of _yield_result, it uses members query._fields_to_fetch_token, query.is_project_into and query.invoke_after_stream_executed without ever checking for the type.
| self.request_executor.execute_command(command, self.session_info) | ||
|
|
||
| result = stream_operation.set_result(command.result) | ||
| return DocumentSession._Advanced._StreamIterator(self, result, None, False, None, object_type) |
There was a problem hiding this comment.
can't we make it more public, so we don't need to provide full static path here?
There was a problem hiding this comment.
Created a property that returns it as a type, although I'm not entirely sure it's necessary.
Rebased changes from #168
Fixed issue with duplicated constants files (ravendb/constants.py and ravendb/primitives/constants.py).
Fixed minor issues with class members names and imports.
Made sure tests related to streaming pass.