Skip to content

Commit

Permalink
memref dimensions should be i64 (#400)
Browse files Browse the repository at this point in the history
If you make a memref type with i64::MAX - 1 you will see the output
shows memref<-1xTYPE>

also the pointer in mlir-sys is a *i64

By the way, do you know how to make a memref like memref<?xTYPE> ?
  • Loading branch information
edg-l authored Jan 17, 2024
1 parent 29b95f4 commit 030074a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion melior/src/ir/type/mem_ref.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ impl<'c> MemRefType<'c> {
/// Creates a mem-ref type.
pub fn new(
r#type: Type<'c>,
dimensions: &[u64],
dimensions: &[i64],
layout: Option<Attribute<'c>>,
memory_space: Option<Attribute<'c>>,
) -> Self {
Expand Down

0 comments on commit 030074a

Please sign in to comment.