feat: add to_ref and Deref functions for the context #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raviqqe @Danacus @BadBastion @azteca1998 PTAL. Thank you! ❤️ |
Signed-off-by: peefy <[email protected]>
Peefy
force-pushed
the
feat-add-context-to-ref
branch
from
d1da321
to
2dfb480
Compare
|
Thank you for the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am one of the users of Melbourne and have found that ContextRef does not have a publicly available method to convert to
&'c Context, so I've opened this PR to add theto_reffunction for the context like theOperationRefdoes at https://github.com/raviqqe/melior/blob/main/melior/src/ir/operation.rs