-
Notifications
You must be signed in to change notification settings - Fork 431
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
1f98126
commit 6f4a749
Showing
15 changed files
with
57 additions
and
56 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
module github.com/ray-project/kuberay/cli | ||
|
||
go 1.19 | ||
go 1.20 | ||
|
||
require ( | ||
github.com/fatih/color v1.13.0 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,11 +4,11 @@ This section walks through how to build and test the operator in a running Kuber | |
|
||
## Requirements | ||
|
||
software | version | link | ||
:------------- | :---------------:| -------------: | ||
kubectl | v1.21.0+ | [download](https://kubernetes.io/docs/tasks/tools/install-kubectl/) | ||
go | v1.19|[download](https://golang.org/dl/) | ||
docker | 19.03+|[download](https://docs.docker.com/install/) | ||
| software | version | link | | ||
|:---------|:--------:|--------------------------------------------------------------------:| | ||
| kubectl | v1.21.0+ | [download](https://kubernetes.io/docs/tasks/tools/install-kubectl/) | | ||
| go | v1.20 | [download](https://golang.org/dl/) | | ||
| docker | 19.03+ | [download](https://docs.docker.com/install/) | | ||
|
||
Alternatively, you can use podman (version 4.5+) instead of docker. See [podman.io](https://podman.io/getting-started/installation) for installation instructions. The Makefile allows you to specify the container engine to use via the `ENGINE` variable. For example, to use podman, you can run `ENGINE=podman make docker-build`. | ||
|
||
|
@@ -18,14 +18,14 @@ The instructions assume you have access to a running Kubernetes cluster via `kub | |
|
||
For local development, we recommend using [Kind](https://kind.sigs.k8s.io/) to create a Kubernetes cluster. | ||
|
||
### Use go v1.19 | ||
### Use go v1.20 | ||
|
||
Currently, KubeRay uses go v1.19 for development. | ||
Currently, KubeRay uses go v1.20 for development. | ||
|
||
```bash | ||
go install golang.org/dl/go1.19.12@latest | ||
go1.19.12 download | ||
export GOROOT=$(go1.19. env GOROOT) | ||
go install golang.org/dl/go1.20.11@latest | ||
go1.20.11 download | ||
export GOROOT=$(go1.20. env GOROOT) | ||
export PATH="$GOROOT/bin:$PATH" | ||
``` | ||
|
||
|
@@ -166,7 +166,7 @@ IMG=kuberay/operator:nightly make deploy | |
|
||
KubeRay uses the gofumpt linter. | ||
|
||
Download gofumpt version **0.5.0**. At the time of writing, v0.5.0 is the latest version compatible with go1.19. Run this command to download it: | ||
Download gofumpt version **0.5.0**. At the time of writing, v0.5.0 is the latest version compatible with go1.20. Run this command to download it: | ||
|
||
```bash | ||
go install mvdan.cc/[email protected] | ||
|
@@ -181,14 +181,14 @@ gofumpt --version | |
# v0.5.0 (go1.19) | ||
``` | ||
|
||
Make sure your `go` version is still 1.19: | ||
Make sure your `go` version is still 1.20: | ||
|
||
```bash | ||
go version | ||
# go version go1.19 darwin/amd64 | ||
# go version go1.20 darwin/amd64 | ||
``` | ||
|
||
If your `go` version isn’t 1.19 any more, you may have installed a different `gofumpt` version (e.g. by downloading with Homebrew). If you accidentally installed `gofumpt` using Homebrew, run `brew uninstall gofumpt` and then `brew uninstall go`. Then check `brew install go@1.19`. It should be back to 1.19.x. | ||
If your `go` version isn’t 1.20 any more, you may have installed a different `gofumpt` version (e.g. by downloading with Homebrew). If you accidentally installed `gofumpt` using Homebrew, run `brew uninstall gofumpt` and then `brew uninstall go`. Then check `brew install go@1.20`. It should be back to 1.20.x. | ||
|
||
Whenever you edit KubeRay code, run the `gofumpt` linter inside the KubeRay directory: | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters