-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding capability to create ray cluster with serve support #1582
Conversation
@kevin85421 I was waiting for a while to implement this and it turned out to be extremely simple. The amount of additional code is minimal, so I assume this is not a big deal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contributions! I've left some comments. Would you or someone from IBM/Red Hat mind manually testing this PR to ensure that the Kubernetes service is created successfully and selects the correct Ray Pods after addressing the comments?
I have also double-checked that everything works and added a little readme for using this from the API server |
The error here is due to the age of the PR. I can rebase it, but this will bloat the PR with a lot of things, that are not relevant |
The commit 8bfc8d6 only has a new doc. Maybe you forgot to
If you rebase it correctly, it should not bloat with irrelevant things. |
# Conflicts: # ray-operator/controllers/ray/common/service_test.go
@kevin85421 PR is rebased. |
Your rebase process seems to have some issues. It adds a lot of irrelevant things to this PR. Maybe we can open a new PR instead? |
Thats how rebase works, sorry. These additional things are completely harmless, as they come from git. They are already there |
I guess you did not resolve the conflicts correctly before continuing with |
Why are these changes needed?
Currently, RayCluster CRD does not provide capabilities to create a cluster that can be used for Ray Serve. The only way to create such a cluster is to use RayServe CRD. This PR overcomes this by creating a cluster supporting Ray serve if an annotation
"ray.io/enableAgentService": "true"
is added to the cluster.Related issue number
closes https://github.com/ray-project/kuberay
Checks