Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Improve observability for flaky RayJob test #1587

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Oct 31, 2023

Why are these changes needed?

  1. Improve observability for troubleshooting.
  2. Increase the probability to trigger the flakiness.

Related issue number

#1550

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@kevin85421 kevin85421 marked this pull request as ready for review November 1, 2023 22:22
Copy link
Contributor

@architkulkarni architkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not increase the timeout to 15 as suggested in the original issue? Is it really a bug if it takes longer than 1s to set the dashboard URL?

@kevin85421
Copy link
Member Author

kevin85421 commented Nov 1, 2023

Why not increase the timeout to 15 as suggested in the original issue? Is it really a bug if it takes longer than 1s to set the dashboard URL?

We should first determine whether this is a bug. If it's not, we can increase the timeout to 15s. However, if it is a bug, increasing the timeout might obscure the actual root cause. This PR is used to confirm whether this is a bug or not.

Copy link
Contributor

@architkulkarni architkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

@kevin85421 kevin85421 merged commit 244003b into ray-project:master Nov 2, 2023
16 checks passed
kevin85421 added a commit to kevin85421/kuberay that referenced this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants