[Doc] Update release docs #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin85421
commented
Nov 2, 2023
| @@ -35,7 +35,7 @@ You can validate the charts as follows: | |||
| # Install charts | |||
| helm install kuberay-operator kuberay/kuberay-operator | |||
| helm install kuberay-apiserver kuberay/kuberay-apiserver | |||
| helm install ray-cluster kuberay/ray-cluster | |||
| helm install raycluster kuberay/ray-cluster | |||
There was a problem hiding this comment.
Almost all KubeRay docs use helm install raycluster instead of helm install ray-cluster.
kevin85421
commented
Nov 2, 2023
| @@ -77,24 +77,24 @@ You will be prompted for a commit reference and an image tag. The commit referen | |||
| * The [image release CI pipeline](https://github.com/ray-project/kuberay/blob/master/.github/workflows/image-release.yaml) also publishes the `github.com/ray-project/kuberay/[email protected]` Go module. KubeRay has supported Go modules since v0.6.0. Follow these instructions to verify the Go module installation. | |||
| ```sh | |||
| # Install the module. This step is highly possible to fail because the module is not available in the proxy server. | |||
| go install github.com/ray-project/kuberay/ray-operator@v0.5.0-rc.0 | |||
| go install github.com/ray-project/kuberay/ray-operator@v1.0.0-rc.0 | |||
There was a problem hiding this comment.
It is weird that we say "KubeRay has supported Go modules since v0.6.0", but use v0.5.0-rc.0 as an example.
kevin85421
commented
Nov 2, 2023
| ``` | ||
|
|
||
| * Release rc0 Helm charts following the [instructions](../release/helm-chart.md). | ||
|
|
||
| * Open a PR into the Ray repo updating the operator version used in the autoscaler integration test. Make any adjustments necessary for the test to pass ([example](https://github.com/ray-project/ray/pull/33987)). Make sure the test labelled [kubernetes-operator](https://buildkite.com/ray-project/oss-ci-build-pr/builds/17146#01873a69-5ccf-4c71-b06c-ae3a4dd9aecb) passes before merging. | ||
| * Open a PR into the Ray repo updating the operator version used in the autoscaler integration test. Make any adjustments necessary for the test to pass ([example](https://github.com/ray-project/ray/pull/40918)). Make sure the test labelled [kubernetes-operator](https://buildkite.com/ray-project/oss-ci-build-pr/builds/17146#01873a69-5ccf-4c71-b06c-ae3a4dd9aecb) passes before merging. |
There was a problem hiding this comment.
There is one more place in the Ray repo that needs to be updated, so I updated the reference link.
architkulkarni
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks