Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RayService][Hotfix] Hotfix for Flaky Zero Downtime Rollout Test #1837

Merged
merged 2 commits into from
Jan 17, 2024
Merged

[RayService][Hotfix] Hotfix for Flaky Zero Downtime Rollout Test #1837

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43f1e4e
fix flaky test
Yicheng-Lu-llll Jan 17, 2024
0494679
add todo
Yicheng-Lu-llll Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/test_sample_rayservice_yamls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,13 @@ def wait(self):
assert current_cluster_name != self.old_cluster_name
logger.info(f'Ray service has moved to cluster "{current_cluster_name}"')

# Wait 20 seconds for the serve service to update.
# TODO (Yicheng-Lu-llll): This workaround should be removed after
# refactoring the way of rolling out and redefining service status.
# Currently, changing to 'running' status does not guarantee that
# the serve service will redirect traffic to the new Raycluster.
time.sleep(20)

class RayServiceDeleteCREvent(CREvent):
"""CREvent for RayService deletion"""
def exec(self):
Expand Down
Loading