[RayService] Refactor to Rely More on RayService Status in RayService E2E Tests #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yicheng-Lu-llll <[email protected]>
kevin85421
reviewed
Feb 21, 2024
| (2) All head pods and worker pods are "Running". | ||
| (3) Service named "rayservice-sample-serve" presents | ||
| (1) serviceStatus is "Running", This means serve applications in Raycluster are ready to serve incoming traffic. | ||
| (2) numServeEndpoints > 0, This means the k8s serve service is ready to redirect traffic to the Raycluster. |
There was a problem hiding this comment.
Suggested change
| (2) numServeEndpoints > 0, This means the k8s serve service is ready to redirect traffic to the Raycluster. | |
| (2) numServeEndpoints > 0: This means the k8s serve service is ready to redirect traffic to the RayCluster. |
| (1) The number of head pods and worker pods are as expected. | ||
| (2) All head pods and worker pods are "Running". | ||
| (3) Service named "rayservice-sample-serve" presents | ||
| (1) serviceStatus is "Running", This means serve applications in Raycluster are ready to serve incoming traffic. |
There was a problem hiding this comment.
Suggested change
| (1) serviceStatus is "Running", This means serve applications in Raycluster are ready to serve incoming traffic. | |
| (1) serviceStatus is "Running": This means serve applications in RayCluster are ready to serve incoming traffic. |
kevin85421
approved these changes
Feb 21, 2024
Signed-off-by: Yicheng-Lu-llll <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
After this PR:
RayServiceAddCREventusesserviceStatusandnumServeEndpointsto check if it has converged. This addresses the issue described here: [RayService][HA] Fix flaky tests #1823 (comment). CheckingserviceStatusensures serve applications within the RayCluster are prepared to handle incoming traffic, and verifyingnumServeEndpoints > 0confirms that the k8s serve service is ready to redirect traffic to the RayCluster.RayServiceUpdateCREventalso usesserviceStatusandnumServeEndpointsto check if it has converged. This addresses the issue described here: Remove Extra Delay for Zero Downtime Rollout Test #1838 asnumServeEndpoints > 0can potentially indicate whether the serve service is ready to redirect traffic.RayServiceDeleteCREventchecks for convergence based on the existence of RayService and RayCluster objects. This is similar to how RayJob e2e tests check for deletion.Related issue number
Closes #1838
Checks