Fix v6e TPU Scripts and RayJob CRs #2447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan O'Leary <[email protected]>
|
cc: @andrewsykim |
Signed-off-by: Ryan O'Leary <[email protected]>
andrewsykim
reviewed
Oct 16, 2024
Signed-off-by: Ryan O'Leary <[email protected]>
andrewsykim
approved these changes
Oct 16, 2024
Signed-off-by: Ryan O'Leary <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Follow up to #2445, this PR modifies
tpu_list_devices.pyto get the number of TPU devices fromray.available_resourcesrather than a runtime environment variable. Additionally, this PR renames the RayJob CRs to include the accelerator and chip size (in case we add more single or multi-host examples).Related issue number
Checks