Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Check RayService can successfully create RayCluster #2475

Merged
merged 1 commit into from
Oct 31, 2024
Merged

[Test] Check RayService can successfully create RayCluster #2475

merged 1 commit into from
Oct 31, 2024

Conversation

win5923
Copy link
Contributor

@win5923 win5923 commented Oct 27, 2024 •
edited
Loading

Why are these changes needed?

  • add rayservice_test.go to check RayService can successfully create RayCluster

The skipped tests are as follows:

  • ray-service-alb-ingress.yaml
  • ray-service.autoscaler.yaml
  • ray-service.gke-http-gateway-ingress.yaml
  • ray-service.gke-model-configmap.yaml
  • ray-service.high-availability-locust.yaml
  • ray-service.mobilenet.yaml
  • ray-service.stable-diffusion.yaml
  • ray-service.text-summarizer.yaml
  • ray-service.tpu-single-host.yaml
  • ray-service.text-ml.yaml

Related issue number

Closes #2453

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@win5923
Copy link
Contributor Author

win5923 commented Oct 27, 2024

cc @MortalHappiness

@win5923 win5923 force-pushed the test/checkRayService branch from 2cf1589 to 73ae446 Compare October 28, 2024 17:50
@win5923
Copy link
Contributor Author

win5923 commented Oct 28, 2024 •
edited
Loading

The skipped tests are as follows:

  • ray-service-alb-ingress.yaml
  • ray-service.autoscaler.yaml
  • ray-service.gke-http-gateway-ingress.yaml
  • ray-service.gke-model-configmap.yaml
  • ray-service.high-availability-locust.yaml
  • ray-service.mobilenet.yaml
  • ray-service.stable-diffusion.yaml
  • ray-service.text-summarizer.yaml
  • ray-service.tpu-single-host.yaml

I think ray-service.text-ml.yaml also need to be skipped. It seems the CI has been stalled for a long time.

https://buildkite.com/ray-project/ray-ecosystem-ci-kuberay-ci/builds/5078#0192d441-7234-4467-ae62-285a5d94cb59

edited:

added ray-service.text-ml.yaml to the skip list.

@win5923 win5923 force-pushed the test/checkRayService branch from 73ae446 to 592950d Compare October 28, 2024 18:21
@win5923 win5923 force-pushed the test/checkRayService branch from 592950d to 9fbccb2 Compare October 29, 2024 12:43
@win5923 win5923 marked this pull request as draft October 29, 2024 13:05
@win5923 win5923 force-pushed the test/checkRayService branch from 9fbccb2 to 7df0825 Compare October 29, 2024 13:06
@win5923 win5923 marked this pull request as ready for review October 29, 2024 13:06
MortalHappiness
MortalHappiness approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@MortalHappiness MortalHappiness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kevin85421
kevin85421 reviewed Oct 29, 2024
View reviewed changes
ray-operator/test/sampleyaml/rayservice_test.go Outdated Show resolved Hide resolved
ray-operator/test/sampleyaml/rayservice_test.go Outdated Show resolved Hide resolved
ray-operator/test/sampleyaml/rayservice_test.go Outdated Show resolved Hide resolved
ray-operator/test/sampleyaml/rayservice_test.go Outdated Show resolved Hide resolved
@win5923 win5923 changed the title [Test] add test for RayService job creation in RayCluster head pod [Test] Check RayService can successfully create RayCluster Oct 30, 2024
@win5923 win5923 force-pushed the test/checkRayService branch from c171227 to fbbcd69 Compare October 30, 2024 05:34
@win5923 win5923 marked this pull request as draft October 30, 2024 05:40
@win5923 win5923 force-pushed the test/checkRayService branch from fbbcd69 to d508443 Compare October 30, 2024 05:45
@win5923 win5923 marked this pull request as ready for review October 30, 2024 05:46
@kevin85421 kevin85421 merged commit ebd99da into ray-project:master Oct 31, 2024
29 checks passed
@win5923 win5923 deleted the test/checkRayService branch November 1, 2024 01:14
@frivas-at-navteca frivas-at-navteca mentioned this pull request Nov 19, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MortalHappiness MortalHappiness MortalHappiness approved these changes

@kevin85421 kevin85421 kevin85421 left review comments

Assignees

@kevin85421 kevin85421

@MortalHappiness MortalHappiness

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check RayService can successfully create RayCluster
3 participants
@win5923 @kevin85421 @MortalHappiness