[Feature][RayService]Add kubernetes event to inform user of upgrade strategy #2592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiayi
force-pushed
the
rayservice-upgrade
branch
3 times, most recently
from
9ea70da to
b9b7186
Compare
andrewsykim
reviewed
Dec 3, 2024
| } | ||
| r.Recorder.Event(rayServiceInstance, "Normal", "UpgradeStrategy", strategyMessage) |
There was a problem hiding this comment.
I think we previsouly discussed this event only being emitted when the upgrade is triggered. Is this the case if we only emit the event when the cluster action is RolloutNew?
There was a problem hiding this comment.
Changed to only emit event if zero downtime triggers an upgrade.
I've also went back to do another manual test to check the behavior of zero downtime (before changing the event to only emit on upgrade). When there is an upgrade with the "RolloutNew" but with zero downtime disabled, it will continue to retry:
chiayi
force-pushed
the
rayservice-upgrade
branch
2 times, most recently
from
c3d89bb to
5dfc132
Compare
chiayi
force-pushed
the
rayservice-upgrade
branch
from
5dfc132 to
31f171a
Compare
|
chiayi
force-pushed
the
rayservice-upgrade
branch
from
31f171a to
68f0388
Compare
andrewsykim
reviewed
Dec 18, 2024
chiayi
force-pushed
the
rayservice-upgrade
branch
2 times, most recently
from
53da055 to
b385ebf
Compare
chiayi
force-pushed
the
rayservice-upgrade
branch
from
b385ebf to
d78a439
Compare
andrewsykim
approved these changes
Dec 18, 2024
Open
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adds Kubernetes Event to inform users of upgrade strategy. Ex:
Related issue number
Part of #2554
Checks