[CI] Deflaky TestRayServiceGCSFaultTolerance #2660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kaihsun <[email protected]>
kevin85421
commented
Dec 17, 2024
| @@ -15,7 +15,7 @@ spec: | |||
| args: | |||
| num_forwards: 0 | |||
| runtime_env: | |||
| working_dir: https://github.com/ray-project/serve_workloads/archive/a2e2405f3117f1b4134b6924b5f44c4ff0710c00.zip | |||
| working_dir: https://github.com/ray-project/serve_workloads/archive/a9f184f4d9ddb7f9a578502ae106470f87a702ef.zip | |||
There was a problem hiding this comment.
See #2303 (comment) for more details.
MortalHappiness
approved these changes
Dec 17, 2024
|
cc @CheyuWu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
#2590 adds an e2e test for RayService HA with GCS FT. However, it is quite flaky. On my devbox, it has about a 50% chance of failing.
The reason is that when the GCS process on the head Pod is killed, the readiness/liveness probes on the worker Pod will fail for a while, causing some requests to be dropped. I no longer observe the issue after upgrading from Ray 2.9.0 to Ray 2.40.0.
Related issue number
Closes #2659
Checks
I ran the test 10 times with this PR. All passed.