[kubectl-plugin] add --worker-gpu flag for cluster creation #2675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Sy Kim <[email protected]>
|
@chiayi PTAL |
chiayi
reviewed
Dec 20, 2024
| @@ -85,6 +89,7 @@ func TestConvertRayClusterApplyConfigToYaml(t *testing.T) { | |||
| WorkerReplicas: 3, | |||
| WorkerCPU: "2", | |||
| WorkerMemory: "10Gi", | |||
| WorkerGPU: "0", | |||
There was a problem hiding this comment.
Do you think it is worth it to check the yaml output when the GPU is non-zero? Or is it enough to see that the value is properly set in the applyconfig?
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Add the option to specify worker GPU count. For now we default to nvidia.com/gpu but we can support other GPU types in the future.
Related issue number
#2608
Checks