[RayCluster][CI] add e2e tests for the RayClusterSuspended status condition #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rueian
force-pushed
the
e2e-raycluster-status-condition-suspend
branch
2 times, most recently
from
942653f to
1940441
Compare
rueian
commented
Dec 25, 2024
| sema := make(chan struct{}, 3) | ||
| for i := 0; i < cap(sema); i++ { | ||
| sema <- struct{}{} | ||
| } |
There was a problem hiding this comment.
This e2e test now takes too long (~30min) and timeouts the CI. So we parallelize the sub-tests with a semaphore to allow 3 parallelism.
kevin85421
reviewed
Dec 25, 2024
rueian
force-pushed
the
e2e-raycluster-status-condition-suspend
branch
4 times, most recently
from
0b77dcb to
ca6c370
Compare
Signed-off-by: Rueian <[email protected]>
Signed-off-by: Rueian <[email protected]>
rueian
force-pushed
the
e2e-raycluster-status-condition-suspend
branch
from
ca6c370 to
4fa9409
Compare
kevin85421
reviewed
Dec 27, 2024
| name string | ||
| }{ | ||
| { | ||
| name: "ray-cluster.complete.yaml", |
There was a problem hiding this comment.
Construct the RayCluster with ApplyConfiguration like this. I prefer to avoid relying on external YAML files as much as possible.
There was a problem hiding this comment.
Hi @kevin85421, this is ready.
rueian
force-pushed
the
e2e-raycluster-status-condition-suspend
branch
from
9690d80 to
540308b
Compare
… folder Signed-off-by: Rueian <[email protected]>
rueian
force-pushed
the
e2e-raycluster-status-condition-suspend
branch
from
540308b to
34484bd
Compare
kevin85421
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Continue #2661, add e2e tests for the RayClusterSuspended status condition to sampleyaml tests.
Related issue number
Checks