[Grafana] Use PodMonitor instead of ServiceMonitor for the Head Node to avoid metric duplication #2689
+39
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to avoid metric duplication Signed-off-by: win5923 <[email protected]>
|
@kevin85421 PTAL when you are free. |
kevin85421
approved these changes
Dec 27, 2024
kevin85421
approved these changes
Dec 27, 2024
Thanks! |
2 tasks
8 tasks
rynewang
pushed a commit
to ray-project/ray
that referenced
this pull request
Jan 7, 2025
Since KubeRay has changed the collection of Head Node metrics from `ServiceMonitor` to `PodMonitor`, this PR will update the Ray doc to reflect the current usage. Ref: ray-project/kuberay#2689 --------- Signed-off-by: win5923 <[email protected]> Signed-off-by: Blocka <[email protected]> Co-authored-by: Kai-Hsun Chen <[email protected]> Co-authored-by: angelinalg <[email protected]>
roshankathawate
pushed a commit
to roshankathawate/ray
that referenced
this pull request
Jan 7, 2025
…9476) Since KubeRay has changed the collection of Head Node metrics from `ServiceMonitor` to `PodMonitor`, this PR will update the Ray doc to reflect the current usage. Ref: ray-project/kuberay#2689 --------- Signed-off-by: win5923 <[email protected]> Signed-off-by: Blocka <[email protected]> Co-authored-by: Kai-Hsun Chen <[email protected]> Co-authored-by: angelinalg <[email protected]>
roshankathawate
pushed a commit
to roshankathawate/ray
that referenced
this pull request
Jan 9, 2025
…9476) Since KubeRay has changed the collection of Head Node metrics from `ServiceMonitor` to `PodMonitor`, this PR will update the Ray doc to reflect the current usage. Ref: ray-project/kuberay#2689 --------- Signed-off-by: win5923 <[email protected]> Signed-off-by: Blocka <[email protected]> Co-authored-by: Kai-Hsun Chen <[email protected]> Co-authored-by: angelinalg <[email protected]> Signed-off-by: Roshan Kathawate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Addresses: #2502 (comment)
This issue is caused by RayService. The Head Node is monitored using ServiceMonitor, while RayService creates two Services:
This results in the Head Node's metrics being duplicated. Switching to PodMonitor resolves this issue.
TODO:
Before:
After:
Related issue number
Checks