[apiserver] Start apiserver v2 in apiserver/cmd/main.go #3603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Troy Chiu <[email protected]>
troychiu
changed the title
|
@rueian could you take a look? Thank you |
rueian
reviewed
May 14, 2025
Signed-off-by: Troy Chiu <[email protected]>
|
@kevin85421 PTAL thank you! |
kevin85421
reviewed
May 14, 2025
Signed-off-by: Troy Chiu <[email protected]>
rueian
reviewed
May 15, 2025
kevin85421
reviewed
May 16, 2025
There was a problem hiding this comment.
I chatted with @rueian yesterday. Our conclusions are:
- v1.4.0 is the last release where we fix bugs and add new features for v1.
- We want to launch both v1 and v2 at the same time so that users can incrementally migrate from v1 to v2, and don't need to be 100% one time.
- We don't want to create a new quay repository such as
kuberay/apiserverv2. This may increase the complexity of migration. - For v1.5.0, the image ``kuberay/apiserver` will be v2 only.
apiserver/cmd/main.go
Outdated
| @@ -144,8 +146,19 @@ func startHttpProxy() { | |||
| registerHttpHandlerFromEndpoint(ctx, api.RegisterRayServeServiceHandlerFromEndpoint, "ServeService", runtimeMux) | |||
| registerHttpHandlerFromEndpoint(ctx, api.RegisterRayJobSubmissionServiceHandlerFromEndpoint, "RayJobSubmissionService", runtimeMux) | |||
|
|
|||
| kubernetesConfig, err := config.GetConfig() | |||
There was a problem hiding this comment.
Can you also add a feature gate (maybe a env var) for users to disable v2?
There was a problem hiding this comment.
I added a flag instead, since that has been a pattern in api server
4 tasks
Signed-off-by: Troy Chiu <[email protected]>
Signed-off-by: Troy Chiu <[email protected]>
Signed-off-by: Troy Chiu <[email protected]>
troychiu
commented
May 20, 2025
| @@ -28,6 +25,8 @@ require ( | |||
| github.com/grpc-ecosystem/go-grpc-prometheus v1.2.0 | |||
| github.com/grpc-ecosystem/grpc-gateway/v2 v2.26.3 | |||
| github.com/onsi/gomega v1.37.0 | |||
| github.com/ray-project/kuberay/apiserversdk v0.0.0-20250519054718-f3ebea713a2f | |||
There was a problem hiding this comment.
since apiserversdk hasn't been released. I use the master commit instead.
troychiu
commented
May 20, 2025
| @@ -28,6 +25,8 @@ require ( | |||
| github.com/grpc-ecosystem/go-grpc-prometheus v1.2.0 | |||
| github.com/grpc-ecosystem/grpc-gateway/v2 v2.26.3 | |||
| github.com/onsi/gomega v1.37.0 | |||
| github.com/ray-project/kuberay/apiserversdk v0.0.0-20250519054718-f3ebea713a2f | |||
| github.com/ray-project/kuberay/ray-operator v1.3.1 | |||
There was a problem hiding this comment.
I did some survey and this should be a better practice. That is, we should use a version instead of a local placeholder (v0.0.0-00010101000000-000000000000)
Eventually I think we should either use go workspace or only keep one root go.mod
Signed-off-by: Troy Chiu <[email protected]>
rueian
reviewed
May 20, 2025
Signed-off-by: Troy Chiu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR start apiserver v2 in
apiserver/cmd/main.goto ship the apiserver v2.Related issue number
Closes #3596
Checks