[Refactor] Seperate CI config of ray-operator and apiserver e2e tests #3614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt YAML file Signed-off-by: Cheng-Yeh Chung <[email protected]>
Signed-off-by: Cheng-Yeh Chung <[email protected]>
|
The main issue to me is that one of the 3 types of jobs ( ray-operator, kubectl-plugin, apiserver) is defined in a seperate YAML file (kubectl-plugin), which makes me confused about where is the jobs of apiserver. In this case, combining all jobs into single file is also an alternative if it's a better way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Current CI jobs of ray-operator e2e tests and apiserver e2e tests use the same YAML files, while kubectl-plugin use an independent YAML file. This makes e2e tests of apiserver less discoverable in
.buildkite/test-e2e.yml.This PR separates the jobs of apiserver e2e tests into individual YAML files to improve clarity.
Related issue number
Checks