Skip to content

[Test][Autoscaler] Add an E2E test for CPU tasks on GPU nodes. #3629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 20, 2025
Merged

[Test][Autoscaler] Add an E2E test for CPU tasks on GPU nodes. #3629

merged 4 commits into from
May 20, 2025
+68 −0

Conversation

LeoLiao123
Copy link
Contributor

Why are these changes needed?

See #3615

Related issue number

Closes #3615

Manual tests

command :

go test -timeout 30m -v ./test/e2eautoscaler -run TestRayClusterAutoscalerGPUNodesForCPUTasks

result :
e2e-gpu-node-cpu-task-res

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@LeoLiao123 LeoLiao123 changed the title Test/add e2e cpu on gpu node [Test][Autoscaler] Add an E2E test for CPU tasks on GPU nodes. May 18, 2025
@LeoLiao123 LeoLiao123 marked this pull request as ready for review May 18, 2025 09:42
@LeoLiao123
Copy link
Contributor Author

@rueian PTAL

rueian
rueian approved these changes May 18, 2025
View reviewed changes
Copy link
Contributor

@rueian rueian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rueian
Copy link
Contributor

rueian commented May 19, 2025

cc @kevin85421 for review.

@rueian rueian requested a review from kevin85421 May 19, 2025 19:30
@LeoLiao123 LeoLiao123 requested a review from kevin85421 May 20, 2025 04:47
@LeoLiao123
ci: re-trigger workflow
b07682e 
Signed-off-by: LeoLiao123 <[email protected]>
@kevin85421 kevin85421 merged commit 768b29e into ray-project:master May 20, 2025
24 checks passed
@LeoLiao123 LeoLiao123 deleted the test/add-e2e-cpu-on-gpu-node branch May 20, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rueian rueian rueian approved these changes

@kevin85421 kevin85421 Awaiting requested review from kevin85421

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Test][Autoscaler] Add an E2E test for CPU tasks on GPU nodes.
3 participants
@LeoLiao123 @rueian @kevin85421