Skip to content

Conversation

@alanwguo
Copy link
Contributor

@alanwguo alanwguo commented Oct 3, 2025

Why are these changes needed?

There have been some steady improvements to the grafana dashboards, updating kube-ray's static dashboard configs to have the latest version.

Also adds instructions for the process of updating for future devs.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@alanwguo alanwguo requested review from kevin85421 and win5923 October 3, 2025 23:45
Copy link
Collaborator

@win5923 win5923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alanwguo! I think we can wait to merge until the default Ray version is upgraded to 2.49.2 in Kuberay.

Maybe in 1.5.0

@alanwguo
Copy link
Contributor Author

alanwguo commented Oct 9, 2025

Thanks @alanwguo! I think we can wait to merge until the default Ray version is upgraded to 2.49.2 in Kuberay.

Maybe in 1.5.0

thanks, sounds good. Is there a place I can track the status of that? Or will someone merge this for me automatically once that's done?

First time contributing to kube-ray.

@win5923
Copy link
Collaborator

win5923 commented Oct 9, 2025

thanks, sounds good. Is there a place I can track the status of that? Or will someone merge this for me automatically once that's done?

Yes, I’ll ping @Future-Outlier to help with this once we upgrade the default Ray version to 2.49.2.

Copy link
Collaborator

@ryanaoleary ryanaoleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was able to test this PR and see the updated dashboards show up correctly:
tpu-tab-metrics
updated-metrics-tab

It'd be really helpful if this PR can be included in KubeRay v1.5.0, because it enables users to view TPU metrics that are now collected in Ray 2.49 in the dashboard, otherwise the panels fail to render: ray-project/ray#57829.

Copy link
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ray_cluster_active_nodes -> autoscaler_active_nodes
ray_cluster_pending_nodes -> autoscaler_pendinodes
ray_cluster_recently_failed_nodes -> autoscaler_recently_failed_nodes

@Future-Outlier
Copy link
Member

Cc @rueian for merge, thank you!

@rueian rueian merged commit 247b7ca into ray-project:master Oct 18, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants