-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix serve start namespace issue and add test (#16291)
- Loading branch information
Showing
3 changed files
with
48 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
import subprocess | ||
import sys | ||
|
||
import pytest | ||
|
||
|
||
@pytest.fixture | ||
def ray_start_stop(): | ||
subprocess.check_output(["ray", "start", "--head"]) | ||
yield | ||
subprocess.check_output(["ray", "stop", "--force"]) | ||
|
||
|
||
def test_start_shutdown(ray_start_stop): | ||
with pytest.raises(subprocess.CalledProcessError): | ||
subprocess.check_output(["serve", "shutdown"]) | ||
|
||
subprocess.check_output(["serve", "start"]) | ||
subprocess.check_output(["serve", "shutdown"]) | ||
|
||
|
||
def test_start_shutdown_in_namespace(ray_start_stop): | ||
with pytest.raises(subprocess.CalledProcessError): | ||
subprocess.check_output(["serve", "-n", "test", "shutdown"]) | ||
|
||
subprocess.check_output(["serve", "-n", "test", "start"]) | ||
subprocess.check_output(["serve", "-n", "test", "shutdown"]) | ||
|
||
|
||
if __name__ == "__main__": | ||
sys.exit(pytest.main(["-v", "-s", __file__])) |