Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core][compiled-graphs][1/N] Polish APIs: execution_timeout, retrieval_timeout, buffer_size_bytes #49326

Merged
merged 4 commits into from
Dec 19, 2024
Merged

[core][compiled-graphs][1/N] Polish APIs: execution_timeout, retrieval_timeout, buffer_size_bytes #49326

merged 4 commits into from
Dec 19, 2024

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Dec 18, 2024 •
edited
Loading

Why are these changes needed?

  • Rename execution_timeout to submit_timeout.
  • Rename retrieval_timeout to get_timeout and update comments.
  • Update comments of buffer_size_bytes

Related issue number

#49051

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@kevin85421 kevin85421 mentioned this pull request Dec 18, 2024
Closed
@kevin85421 kevin85421 marked this pull request as ready for review December 18, 2024 06:02
ruisearch42
ruisearch42 approved these changes Dec 18, 2024
View reviewed changes
python/ray/dag/context.py Outdated
DEFAULT_EXECUTION_TIMEOUT_S = int(os.environ.get("RAY_DAG_execution_timeout", 10))
DEFAULT_RETRIEVAL_TIMEOUT_S = int(os.environ.get("RAY_DAG_retrieval_timeout", 10))
DEFAULT_SUBMIT_TIMEOUT_S = int(os.environ.get("RAY_DAG_submit_timeout", 10))
DEFAULT_GET_TIMEOUT_S = int(os.environ.get("RAY_DAG_get_timeout", 10))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DEFAULT_GET_TIMEOUT_S = int(os.environ.get("RAY_DAG_get_timeout", 10))
DEFAULT_GET_TIMEOUT_S = int(os.environ.get("RAY_CGRAPH_get_timeout", 10))

@kevin85421 kevin85421 added the go add ONLY when ready to merge, run all tests label Dec 18, 2024
@jjyao jjyao merged commit 6c0a2e4 into ray-project:master Dec 19, 2024
5 of 6 checks passed
@kevin85421 kevin85421 assigned kevin85421 and unassigned ruisearch42 Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruisearch42 ruisearch42 ruisearch42 approved these changes

Assignees

@kevin85421 kevin85421

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevin85421 @ruisearch42 @jjyao