[Fix][Core] Wait a while before stopping the ray_print_logs thread to prevent pending logs #49337
+30
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
If the job finishes first but the job submitter hasn't completed polling all the logs, the polling thread being set as a daemon thread may result in some pending logs (logs from the worker running this job that haven't been polled yet) not being printed. This PR changes the print log thread to a regular thread and ensures it only returns after the size of the message queue drops to lower than or equal to 1.
Related issue number
Closes: #48701
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.