Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Refactor ray._private.runtime_env.packaging.Protocol to make it extensible #49341

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Core] Refactor ray._private.runtime_env.packaging.Protocol to make it extensible #49341

wants to merge 4 commits into from
+117 −78

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Dec 18, 2024 •
edited
Loading

Why are these changes needed?

Refactor ray._private.runtime_env.packaging.Protocol to make it extensible via ProtocolsProvider interface.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Dec 18, 2024
@jjyao
up
4225929 
Signed-off-by: Jiajun Yao <[email protected]>
@jjyao jjyao marked this pull request as ready for review December 19, 2024 00:21
brucez-anyscale
brucez-anyscale reviewed Dec 19, 2024
View reviewed changes
Copy link
Contributor

@brucez-anyscale brucez-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jjyao jjyao requested a review from rynewang December 19, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brucez-anyscale brucez-anyscale brucez-anyscale left review comments

@rynewang rynewang Awaiting requested review from rynewang

At least 1 approving review is required to merge this pull request.

Assignees

@rynewang rynewang

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjyao @rynewang @brucez-anyscale