Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Bump batch_inference_hetero timeout #49348

Merged
merged 15 commits into from
Dec 20, 2024
Merged

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Dec 19, 2024

Why are these changes needed?

#49012 decreased number of GPUs for batch_inference_hetero from 40 to 10. As a result, the test has been timeing out. This PR fixes the test by bumping up the timeout.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani bveeramani marked this pull request as draft December 19, 2024 00:57
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani bveeramani marked this pull request as ready for review December 19, 2024 23:54
@srinathk10
Copy link
Contributor

LGTM!

@bveeramani bveeramani enabled auto-merge (squash) December 19, 2024 23:57
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Dec 19, 2024
@bveeramani bveeramani merged commit 980664e into master Dec 20, 2024
7 checks passed
@bveeramani bveeramani deleted the bump-hetero-timeout branch December 20, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants