Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serve] Minor cleanup for gRPC server construction #49944

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[serve] Minor cleanup for gRPC server construction #49944

wants to merge 5 commits into from

Conversation

edoakes
Copy link
Contributor

@edoakes edoakes commented Jan 18, 2025 •
edited
Loading

Why are these changes needed?

  • Add extra_options arg.
  • Remove unnecessary factory function.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@edoakes edoakes added the go add ONLY when ready to merge, run all tests label Jan 18, 2025
@edoakes edoakes requested review from GeneDer and zcin January 18, 2025 14:21
@edoakes
small cleanups
1450275 
Signed-off-by: Edward Oakes <[email protected]>
@edoakes edoakes force-pushed the eoakes/grpc-proxy-cleanup branch from f560966 to 1450275 Compare January 18, 2025 14:22
@edoakes
small cleanups
4d7360f 
Signed-off-by: Edward Oakes <[email protected]>
@edoakes
fix
b846323 
Signed-off-by: Edward Oakes <[email protected]>
@edoakes
fix
74fa67e 
Signed-off-by: Edward Oakes <[email protected]>
@edoakes edoakes changed the title [serve] Minor cleanup for gRPC server options [serve] Minor cleanup for gRPC server construction Jan 18, 2025
@edoakes
fix
ffc4a9a 
Signed-off-by: Edward Oakes <[email protected]>
edoakes
edoakes commented Jan 18, 2025
View reviewed changes
python/ray/serve/tests/unit/test_grpc_util.py
@@ -45,24 +44,10 @@ def test_dummy_servicer_can_take_any_methods():
dummy_servicer.Predict


def test_create_serve_grpc_server():
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test was useless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeneDer GeneDer Awaiting requested review from GeneDer

@zcin zcin Awaiting requested review from zcin

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@edoakes